You could be right, but I don't necessarily agree. FD is still an awesome deal for folks staying at Value resorts.
I agree that the old offer pushed people to Moderates as the cost to upgrade the QS plan to the
DDP was about the same as the cost to upgrade resort levels from Value to Moderate. Essentially you got Value resort pricing with the DDP while staying in a Moderate. But the Moderate resorts fill themselves now, even during slower times of the year. They need to fill Values and Deluxes during those times of the year. The best way to fill a Deluxe is with a room discount. The best way to fill Values is with dining and/or ticket discount packages since a room discount represents such a small portion of the overall WDW cost.
Will FD end? Maybe. But there will always be some sort of discount better than RO for Values during really slow times of the year. If there is not, those resort rooms will sit empty. Maybe some variation of the SPD offer, or buy 4 nights get 3 free. There will be something.